re-doing Bump_comment for version 1.4 #145
Conversation
chazzly
changed the title
|
I like this! Maybe another addition could be to automatically create a tag At the same time, maybe check if a specific (configurable) branch is selected and if that's the case, push both that version bump, changelog change and tag into origin. We'd check for a branch to make sure we are not working within a sub-module that is disconnected from origin for whatever reason. |
|
i'll take a look. |
|
@jonlives, question about spork_config. As I'm working on @TheSerapher 's suggestion, and I'd like to able to set a config setting that will get picked up by another plug-in, even though i'm not directly calling it. I've got spork-bump pulling in a couple config settings. Then, based on those, I would like to pass the comment entered to the git plug-in. Since git is not being called directly, but via the :after_bump hook, I was hoping to alter the spork_config settings for the git plug-in, but can't quite figure out how to reference it. Suggestions? It's probably something simple that I'm missing. |
|
@chazzly plugins are typically only aware of their own config, plus anything passed in via https://github.com/jonlives/knife-spork/blob/master/lib/knife-spork/runner.rb#L42 when the plugins are run. I'm going to bump this from the 1.5.0 milestone to give you a little extra time to finish up here :) |
|
Closing - Superseded by #174 |
I was a noob and royally hosed my fork when trying to bring it in line with 1.4. So, I blew it away and started over. As such, I've closed pull request #123 and I'm re-submitting this (hopefully clean) one.
This adds an option to the spork bump plug-in to prompt the user for a comment about their change (the reason for the bump). This comment is appended to CHANGELOG.md in the following format:
<new_version>
-
The Git plugin was also updated to 'git add CHANGELOG.md' during ":after_bump"
Future ideas/ possible refinements: